ita-social-projects / Home-UI

Home - is an all-in-one social service that will cover all aspects of your communication with your home and neighbors.
3 stars 7 forks source link

Tech debt 372/packaging polls #382

Closed Naira21 closed 2 years ago

Naira21 commented 2 years ago

This pull request has consisted of such work as:

Note: as of today mounted() block in PollForm has try {} catch {} logic, and I would like to suggest leaving it in vue component instead of moving to action.ts as it has really easy logic inside — dispatch store data and invoke initDate() method — which is opposed to the code in actions.ts.

Please, review the code at your convenience Any comments will be much appreciated!

aleonovdementiev commented 2 years ago

It's better to name the root folder for this package - 'poll', not 'polls', because we're discribing a single realization for poll, but not many instances of polls

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication