Bugfix/issue#471 duplication of stored data - Githubissues

ita-social-projects / Home

Home - is an all-in-one social service that will cover all aspects of your communication with your home and neighbors.

http://www.home-project-engineering.tech/api/0/apidocs/index.html

MIT License

26 stars 31 forks source link

Bugfix/issue#471 duplication of stored data #489

Closed ystoikov closed 1 year ago

ystoikov commented 2 years ago

dev

ZenHub

ZenHub ticket #471

Summary of issue

The main application uses the "users" table to store users' credentials. OAuth server uses its own user_credentials table for storing the same data. For this reason, some changes require. It is preferable to store common data in one table without duplication.

Summary of change

Transfer data entities from home-oauth-server to the 'home-data'
Add column user_credentials_id to table users like FK on table user_credentials
Change logoutAll() implementation (redirected credential changes to user_credentials table).

CHECK LIST

[ ] СI passed
[ ] Сode coverage >=95%
[ ] PR is reviewed manually again (to make sure you have 100% ready code)
[ ] All reviewers agreed to merge the PR
[ ] I've checked new feature as logged in and logged out user if needed
[ ] PR meets all conventions

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

87.5% Coverage
0.0% Duplication

vladyslavyarets commented 1 year ago

This task was closed in another branch. PR - https://github.com/ita-social-projects/Home/pull/496