Bugfix/issue#497 creation date is not editable in update cooperation poll - Githubissues

ita-social-projects / Home

Home - is an all-in-one social service that will cover all aspects of your communication with your home and neighbors.

http://www.home-project-engineering.tech/api/0/apidocs/index.html

MIT License

26 stars 31 forks source link

Bugfix/issue#497 creation date is not editable in update cooperation poll #498

Closed vladyslavyarets closed 1 year ago

vladyslavyarets commented 1 year ago

dev

ZenHub

Main ZenHub ticket

Summary of issue

Bug. Error during updating poll. The creation date isn't resettable.

Summary of change

Changed PollServiceImpl.
Fixed updatePollTest() in CooperationPollApiIT. Logic violation fixed: the test succeeded when it shouldn't.
Added updatePollWithPastCreationDateTest() to check happy path to update creationDateTime with wrong date.

Testing approach

Not required

CHECK LIST

[ ] СI passed
[x] Сode coverage >=95%
[x] PR is reviewed manually again (to make sure you have 100% ready code)
[ ] All reviewers agreed to merge the PR
[x] I've checked new feature as logged in and logged out user if needed
[ ] PR meets all conventions

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication