ita-social-projects / OoS-Backend

Out of School: The platform for choosing an extracurricular activity for your children
MIT License
13 stars 6 forks source link

Dolishnii/workshop tags #1561

Closed AndrD1406 closed 1 month ago

AndrD1406 commented 2 months ago

Added Tags to workshops, added respective services, adjusted relations, seeded some initial data.

sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
42.3% Coverage on New Code (required ≥ 80%)
3.3% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

AndrD1406 commented 1 month ago

@VadymLevkovskyi I request a review

VadymLevkovskyi commented 1 month ago

@VadymLevkovskyi I request a review

@AndrD1406 I wish I could, but I can't review the PR having review comments that aren't addressed by either code changes or any comments. (I'm talking about all comments, both given by me and by other teammates as well)

If you don't like suggested changes - please state it directly in reply comments, if you don't understand them - ask directly in reply comments, because right now these comments looks to me like missed and never taken in progress.

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
50.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

AndrD1406 commented 1 month ago

@VadymLevkovskyi I was talking about the new changes, the previous ones are corrected as well now