search

ita-social-projects / TeachUA

The project aims to promote the Ukrainian language for study clubs in Russian-speaking regions of Ukraine. This is a web application that contains a database of clubs with the Ukrainian language of instruction. Clubs have the opportunity to register on the site and provide information about themselves. Users can search for clubs by various parameters (activity type, location, etc.)
MIT License
22 stars 10 forks source link

[API/ Club/ GET] Status code 200 instead of 404 when entered invalid ID for endpoint '/api/clubsByCenterId/{id}' #2139

Open Oksana-Lysak opened 8 months ago

Oksana-Lysak commented 8 months ago

Get clubs by center id with an invalid ID of the center.

Environment: Windows 11 Pro Version 22H2 Build 22621.2428 Google Chrome 118.0.5993.118 (Official build) (64-bit) Reproducible: always Build found: front 2024-01-04 d5b9ee back 2024-01-04 7dd789

Preconditions

  1. Site http://speak-ukrainian.eastus2.cloudapp.azure.com/dev/ is opened.
  2. The center with ID 10000 does not exist in the database
  3. Postman is opened.
  4. The token (admin) is gotten.

Steps to reproduce

  1. Create GET request to 'http://speak-ukrainian.eastus2.cloudapp.azure.com/dev' using endpoint '/api/clubs/search' with an invalid ID of the center "10000"

Actual result 200OK

11

Expected result 404 Not Found

Oksana-Lysak commented 8 months ago

Related: https://github.com/ita-social-projects/TeachUA/issues/2134 https://github.com/ita-social-projects/TeachUA/issues/2139