itaditya / pr-train

FInd which teammates have least PRs to review
MIT License
1 stars 5 forks source link

Make a logo for pr-train #1

Closed itaditya closed 5 years ago

abhayjatindoshi commented 5 years ago

Can you provide more information of what pr-train does to design a logo for it ?

itaditya commented 5 years ago

There's a short description here. I have also added a screenshot of the project in action, so you can get a better idea of what it does.

abhayjatindoshi commented 5 years ago

What does train mean in your app name ? pr means Pull Requests if I'm not wrong ?

itaditya commented 5 years ago

Yeah you are right pr means Pull Request. Train as in the locomotive. Meant to say one person (engine) has to review these many PRs already (carriage boxes).

So you will assign a new PR (carriage) to the person who has to review least PRs (engine which has to pull least carriages).

abhayjatindoshi commented 5 years ago

image

Would this do ?

itaditya commented 5 years ago

This is an interesting idea @abhayjatindoshi. Can you make the railway tracks in form of P? That would resemble a PR flow as well, in the sense that you make a branch from master so so you get

I /
I/
I
I

and once you merge the PR, it goes back to master.

I
I\
I \
I /
I/
I
I

Basically, use the railway tracks to form a P in a logo like this

image
itaditya commented 5 years ago

Here is a Figma file with this logo, you can make the changes there directly https://www.figma.com/file/hcGuaVVyQxLFRvB1E2ljjy/PR-Train-logo?node-id=0%3A1

abhayjatindoshi commented 5 years ago

I think I get you. Let me try what I can do.

abhayjatindoshi commented 5 years ago

This should do I guess ? image

itaditya commented 5 years ago

Looks great! Just add this symbol in the background design I have made and submit a PR with these files named like this

Put everything in folder public

abhayjatindoshi commented 5 years ago

Would you need a png if I get you an SVG ? You would be able to scale to any size on html.

itaditya commented 5 years ago

png is needed for PWA icons. I think svg is not well supported there

abhayjatindoshi commented 5 years ago

Sure then, I'll get those done too. There seems some problem with github when forking 😖😕 I've already informed github support. I'll create a PR once they have it resolved.

itaditya commented 5 years ago

Cool 👍

abhayjatindoshi commented 5 years ago

8

itaditya commented 5 years ago

closed by #8