search

itaditya / pr-train

FInd which teammates have least PRs to review
MIT License
1 stars 5 forks source link

Add a dropdown to select GitHub team. #4

Open itaditya opened 5 years ago

itaditya commented 5 years ago

Currently the GitHub team slug is provided via query params. The few benefits it has are - a) once you visit the URL, the browser will autocomplete next time. b) was very easy to implement.

The downside is when user doesn't provide any query param, the page shows up blank. What we should do is fetch all the teams of the GitHub org and then ask user to select one team via a dropdown.

isamrish commented 5 years ago

I like to do it.

isamrish commented 5 years ago

In order to fetch all the teams of the GitHub org, /api/reviewers should list teams so I added appropriate code and raised PR in pr-train-api-server repo https://github.com/itaditya/pr-train-api-server/pull/1

itaditya commented 5 years ago

Great start @IsAmrish. Will you also add the UI code to select from dropdown here?