search

itaditya / trick-or-treat-game

Play it for free here
https://trick-or-treat.netlify.com/
16 stars 17 forks source link

Add twitter share button #22

Closed kaikecarlos closed 5 years ago

kaikecarlos commented 5 years ago

don't merge, for some reason react-twitter-embed is giving some error(related to babel)

itaditya commented 5 years ago

As discussed here, we don't need a full library for this https://github.com/itaditya/trick-or-treat-game/issues/18#issuecomment-536903130

kaikecarlos commented 5 years ago

oh, I will fix ASAP

itaditya commented 5 years ago

Hi @kaikecarlos thanks for working on this feature. However @bennetthanna has almost completed the feature here and that's why I have assigned that issue to her. But there are lot more issues open. You can pick those up. Another thing you can do is play the game and find issues and then if they seem valid I'll assign those to you.

itaditya commented 5 years ago

@bennetthanna PR has been merged