itaditya / trick-or-treat-game

Play it for free here
https://trick-or-treat.netlify.com/
16 stars 17 forks source link

Add a Scoreboard which stores data in localStorage #24

Closed sohammondal closed 4 years ago

sohammondal commented 4 years ago
itaditya commented 4 years ago

@sohammondal the JS part is fine but design part is not. In my local I have improved the design of your code. Can you grant me edit permissions in your PR, so that I can push my commit to your PR also. Refer this to understand how it is done. https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork

itaditya commented 4 years ago

@sohammondal left some Change Requests as well. Your work is superb. Keep going!!

sohammondal commented 4 years ago

@sohammondal left some Change Requests as well. Your work is superb. Keep going!!

Thank you for the encouragement. 😄 I have updated the code as per the change requests. Please review.

itaditya commented 4 years ago

can you give me access to add commits in your PR https://github.com/itaditya/trick-or-treat-game/pull/24#issuecomment-537149823

sohammondal commented 4 years ago

can you give me access to add commits in your PR #24 (comment)

Hey, I have already [✔️] the checkbox.
image

You should be good to go. Can you please check?

itaditya commented 4 years ago

@sohammondal congratulations on getting your PR merged. This was a significant feature and I'm so happy it got landed.

Congrats

sohammondal commented 4 years ago

@itaditya Thanks for merging the PR. It was a very good learning experience for me. Cheers. 🍻