itaditya / trick-or-treat-game

Play it for free here
https://trick-or-treat.netlify.com/
16 stars 17 forks source link

Refresh button beside "Refresh page to play again" message #26

Open sohammondal opened 5 years ago

konsvasi commented 5 years ago

I will work on this issue.

sohammondal commented 5 years ago

@konsvasi Hey, I have already raised a PR #27 for this. You can work on other issues.

itaditya commented 5 years ago

I think @aelamel has also implemented this although he actually prevents window to reload.

However I find my solution here to be most simple. https://github.com/itaditya/trick-or-treat-game/pull/34

What do you people think?

itaditya commented 5 years ago

I recently got a PR to add service worker to the game. With service workers, all game assets will be cached, and so even if we do window.reload() from a button, it will be very quick. So I'm waiting for the service worker PR to get merged.