search

itaditya / trick-or-treat-game

Play it for free here
https://trick-or-treat.netlify.com/
16 stars 17 forks source link

Move counter is increasing when user is not moving #4

Closed flagoon closed 5 years ago

flagoon commented 5 years ago

When the user's next move is impossible (hitting the wall), he is not "moving" therefore move counter shouldn't increase.

Also, when the game is finished, the counter shouldn't increase on keystroke.

itaditya commented 5 years ago

Nice catch, you should get a :1st_place_medal:

itaditya commented 5 years ago

Also, when the game is finished, the counter shouldn't increase on keystroke.

Fixed in https://github.com/itaditya/collect-squares-game/pull/5

itaditya commented 5 years ago

When the user's next move is impossible (hitting the wall), he is not "moving" therefore move counter shouldn't increase.

Fixed in https://github.com/itaditya/collect-squares-game/pull/6

itaditya commented 5 years ago

@flagoon thank you so much for finding these bugs. Do let me know if you find more of these