Add button to share your score on Twitter

itaditya / trick-or-treat-game

Play it for free here

https://trick-or-treat.netlify.com/

16 stars 17 forks source link

Add button to share your score on Twitter #45

Closed bennetthanna closed 5 years ago

bennetthanna commented 5 years ago

References #18

netlify[bot] commented 5 years ago

You can play this version of the game here

Built with commit 938bcd6d60d835e9fc2eaca23bff49cd880af1d3

https://deploy-preview-45--trick-or-treat.netlify.com

itaditya commented 5 years ago

@bennetthanna thanks for picking this task. Your current approach is not bad but we have a simpler solution which doesn't even need JavaScript.

I have added a comment here https://github.com/itaditya/trick-or-treat-game/issues/18#issuecomment-538078140. Please read it and update accordingly.

bennetthanna commented 5 years ago

@itaditya Here's what the end product looks like. Let me know what you think! I'm open to any and all recommendations 🙂

itaditya commented 5 years ago

This looks great. Can you make one change though. Instead of hardcoding the netlify link, use the window.location.origin to get the location of website and then use that inside the share widget.

itaditya commented 5 years ago

@bennetthanna congrats on getting your PR merged! Happy Hacktoberfest

Congrats