search

itaditya / trick-or-treat-game

Play it for free here
https://trick-or-treat.netlify.com/
16 stars 17 forks source link

Added ScoreBoard component unit test (#57) fixes #56 #57

Closed devTeaa closed 4 years ago

devTeaa commented 4 years ago

As per #56

@itaditya please review my code and let me know if you need any changes, cheers

netlify[bot] commented 4 years ago

You can play this version of the game here

Built with commit 440ef15cb8757058b125a7fafff204b0b11454d5

https://deploy-preview-57--trick-or-treat.netlify.com

itaditya commented 4 years ago

Instead of moving the localStorage logic from ScoreBoard.js to Game.js, you should do this-

devTeaa commented 4 years ago

@itaditya I've made the changes, is this alright?

devTeaa commented 4 years ago

@itaditya sorry, I’ve missed it

devTeaa commented 4 years ago

@itaditya I've changed as per latest review

itaditya commented 4 years ago

@devTeaa Congrats on getting the PR merged. Hope you learned something new by working on this.

Congrats

devTeaa commented 4 years ago

@itaditya I did, thanks a lot for accepting it