search

itagagaki / DeepL-Selected-Text

Translate selected text with DeepL
https://github.com/itagagaki/DeepL-Selected-Text
8 stars 6 forks source link

Feature Request: Allow for Deepl-Write #10

Closed teertinker closed 1 month ago

teertinker commented 1 month ago

Hello, your extension is really useful. Is there a possibility to add an option to switch from deepl translate to deepl write?

I managed to modify your background.js to make it work with deepl write, I simply changed the URL to "https://www.deepl.com/write#"

Another option would be to create just a new Extension, but i think this would just clutter the system.

Thanks

itagagaki commented 1 month ago

Hi, you want a new context menu and a shortcut key (which one do you like?) to send the selected text to DeepL Write, right? I'll try it. Maybe I can do it soon.

teertinker commented 1 month ago

Hello, I first thought an option to switch between deepl-write and translate would be sufficient. But are probably use cases, where people want to use both services. Therefore a new context menu sounds reasonable. I never thought about a shortcut key. So no suggestions from this site.

Thanks for the quick response.

itagagaki commented 1 month ago

If an extension contains more than one context menu, they are collapsed into a single parent menu. This means there is an extra step to get to the function you want. So I decided to create an add-on for the DeepL Write separately from this add-on. Maybe I can publish it in a few days.

itagagaki commented 1 month ago

'DeepL-Write for selected text' is now available for download in the ATN. https://addons.thunderbird.net/addon/deepl-write-for-selected-text/

teertinker commented 1 month ago

Thank you very much!

I tested it and it works!

One problem for me was the min. Version in manifest.json I had to set it to 115 in order to make the extension working on my ubuntu machine. ( "strict_min_version": "115.0",) Since there may be a lot of users with 115ESR still around (Ubuntu does not provide 128 as deb yet), it could be helpful to lower the min. version in the source code.

Anyways. Thanks for developing the tool.

Felix

On Mon, 7 Oct 2024 at 12:10, Itagaki Fumihiko @.***> wrote:

'DeepL-Write for selected text' is now available for download in the ATN. https://addons.thunderbird.net/addon/deepl-write-for-selected-text/

— Reply to this email directly, view it on GitHub https://github.com/itagagaki/DeepL-Selected-Text/issues/10#issuecomment-2396492621, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDL2YJXN4LMWYCB4JGX5M3Z2JMX3AVCNFSM6AAAAABO4OMRHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJWGQ4TENRSGE . You are receiving this because you authored the thread.Message ID: @.***>

itagagaki commented 1 month ago

Glad I could help. I used Manifest V3 for TB128; for TB115 it must be V2, but I don't want to maintain multiple versions. Sorry.