search

italia / Satosa-Saml2Spid

SATOSA SAML-to-SAML proxy with Spid compliances
Apache License 2.0
41 stars 25 forks source link

Feat: instruction for Windows WSL #146

Open Zicchio opened 1 month ago

Zicchio commented 1 month ago

This pull requests includes 2 modifications:

  1. The script for running the docker compose has been modificed so that it can work on Ubuntu when started from WIndows WSL
  2. The docs now specify that the given tool are not guaranteed to work on base Windows.

This is a partial fix to Issue https://github.com/italia/Satosa-Saml2Spid/issues/145

MdreW commented 3 weeks ago

Hi @Zicchio , we can remove the localtime mount in docker-compose.yml because this work is executed in the docker build, dockerfile line 21-25

RUN apk update RUN apk add --update --no-cache tzdata RUN cp /usr/share/zoneinfo/Europe/Rome /etc/localtime RUN echo "Europe/Rome" > /etc/timezone RUN apk del tzdata

@peppelinux , if we don't remove the tzdata package, we can set the timezone with TZ environment, is an "alpine" feature

...but also is so bad UTC? 🤯

MdreW commented 3 weeks ago

A question, are static volumes still necessary? I know, for a remote orchestrated container is a necessary choice, but in this case run-docker-compose.sh script is not useful. Otherwise in a local container istance, have a static mount or a local mount is not different.

If manage the static mount is a problemi with WSL, if we should maintain a mixed mount system (some local and some static), we could turn back with the local mount. We can create the requested directory in Docker-compose path (mongodata for the db, satosa for satosa container file and django_sp for django_sp container file)

At this point the script become a simple utility that copy the example file from the repository directory to the container volume path.

All mount are management with same mode, more simplicity for developers and admins. I'm a old poor person and like the simply life 👴 What do you think?

If is useful I can make a example pull request, It wouldn't take me long.

elisanp commented 1 week ago

Removing the docker volume and using a shared folder could still be a problem for Windows hosts due to this issue https://github.com/docker-library/mongo/issues/232#issuecomment-355423692, that has as a workaround using an external docker volume as suggested here https://github.com/docker-library/mongo/issues/74#issuecomment-238918488