Legacy context API usage

italia / api-oas-checker

An OpenAPI 3 checker based on spectral.

https://italia.github.io/api-oas-checker/

60 stars 24 forks source link

Legacy context API usage #110

Open ioggstream opened 3 years ago

ioggstream commented 3 years ago

I expect

No warnings

Instead

[ ] Warning: Legacy context API has been detected within a strict-mode tree.

The old API will be supported in all 16.x releases, but applications using it should migrate to the new version.

Please update the following components: Transition

[ ] Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node

See

https://reactjs.org/docs/legacy-context.html

emilioSp commented 3 years ago

This is an annoying bug due to our base library used to create react components. See also https://github.com/italia/form-pa/issues/22

@sebbalex do we have a workaround? It's inside the Modal component from design-react-kit.

ioggstream commented 3 years ago

If it's not blocking, deprioritize it in this project. @emilioSp

ioggstream commented 3 years ago

@sebbalex is it ok to priority=low ?

sebbalex commented 3 years ago

@sebbalex do we have a workaround? It's inside the Modal component from design-react-kit.

This is very annoying, it is caused by an unsafe use of lifecycle hooks in a dependency of reactstrap (base library for design-react-kit). As far as I know it should be fixed in next release. @emilioSp we don't have a proper workaround...

@ioggstream yes, we can low priority for this. atm it's just a warning.