search

italia / api-oas-checker

An OpenAPI 3 checker based on spectral.
https://italia.github.io/api-oas-checker/
59 stars 24 forks source link

[WIP] Fix: #587. Bump node to 16 #588

Closed ioggstream closed 2 years ago

ioggstream commented 2 years ago

This PR

bump node 16

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
api-oas-checker ✅ Ready (Inspect) Visit Preview Aug 17, 2022 at 10:30AM (UTC)
ioggstream commented 2 years ago

@astagi after bumping to node 16 I have this issue

  1. open the vercel deployment
  2. select an example file using the "From template" butto

I expect

the editor to be populated

instead

I got a blank page with the following errors in console

Loading errorfile.yaml
main.a0eb7cfd1f591d5b88f3.js:2 TypeError: n is not a function
    at Vl (main.a0eb7cfd1f591d5b88f3.js:2:138247)
    at Gl (main.a0eb7cfd1f591d5b88f3.js:2:138443)
    at cu (main.a0eb7cfd1f591d5b88f3.js:2:158633)
    at main.a0eb7cfd1f591d5b88f3.js:2:153473
    at k (main.a0eb7cfd1f591d5b88f3.js:2:254152)
    at MessagePort.P (main.a0eb7cfd1f591d5b88f3.js:2:254684)
rl @ main.a0eb7cfd1f591d5b88f3.js:2
n.callback @ main.a0eb7cfd1f591d5b88f3.js:2
li @ main.a0eb7cfd1f591d5b88f3.js:2
ss @ main.a0eb7cfd1f591d5b88f3.js:2
ls @ main.a0eb7cfd1f591d5b88f3.js:2
as @ main.a0eb7cfd1f591d5b88f3.js:2
(anonymous) @ main.a0eb7cfd1f591d5b88f3.js:2
uu @ main.a0eb7cfd1f591d5b88f3.js:2
Ks @ main.a0eb7cfd1f591d5b88f3.js:2
Uo @ main.a0eb7cfd1f591d5b88f3.js:2
cu @ main.a0eb7cfd1f591d5b88f3.js:2
(anonymous) @ main.a0eb7cfd1f591d5b88f3.js:2
k @ main.a0eb7cfd1f591d5b88f3.js:2
P @ main.a0eb7cfd1f591d5b88f3.js:2
main.a0eb7cfd1f591d5b88f3.js:2 Uncaught TypeError: n is not a function
    at Vl (main.a0eb7cfd1f591d5b88f3.js:2:138247)
    at Gl (main.a0eb7cfd1f591d5b88f3.js:2:138443)
    at cu (main.a0eb7cfd1f591d5b88f3.js:2:158633)
    at main.a0eb7cfd1f591d5b88f3.js:2:153473
    at k (main.a0eb7cfd1f591d5b88f3.js:2:254152)
    at MessagePort.P (main.a0eb7cfd1f591d5b88f3.js:2:254684)
Vl @ main.a0eb7cfd1f591d5b88f3.js:2
Gl @ main.a0eb7cfd1f591d5b88f3.js:2
cu @ main.a0eb7cfd1f591d5b88f3.js:2
(anonymous) @ main.a0eb7cfd1f591d5b88f3.js:2
k @ main.a0eb7cfd1f591d5b88f3.js:2
P @ main.a0eb7cfd1f591d5b88f3.js:2
emilioSp commented 2 years ago

https://github.com/italia/api-oas-checker/pull/588/commits/f9f651d514a9106a1b5d445c45e98c0c6e111c8d @ioggstream there is also the .nvmrc, for the ones who have node installed directly on their development machine. (like me 😄 )

emilioSp commented 2 years ago

https://github.com/italia/api-oas-checker/pull/588/commits/f9f651d514a9106a1b5d445c45e98c0c6e111c8d @ioggstream there is also the .nvmrc, for the ones who have node installed directly on their development machine.

ioggstream commented 2 years ago

@LorenzoS92 @bfabio come mai non deploya su vercel? Non ho accesso ad oggi. Chi più fixare?

LorenzoS92 commented 2 years ago

Non ho accessi su Vercel al momento. @bfabio puoi aiutarci te? Al rientro, vi chiederò gli accessi.

bfabio commented 2 years ago

@ioggstream we changed the log security setting on Vercel, as there is no private information there, so the logs are publicly visible now: https://vercel.com/dip-trasformazione-digitale/api-oas-checker/9Dm7QcBJ6Q3fQSJTprVATFeBYNH5

[09:47:08.066] Cloning github.com/italia/api-oas-checker (Branch: ioggstream-node16, Commit: 7df029d)
[09:47:08.502] Cloning completed: 436.313ms
[09:47:08.599] Installing build runtime...
[09:47:11.131] Build runtime installed: 2.531s
[09:47:12.192] No Build Cache available
[09:47:12.355] Installing dependencies...
[09:47:12.603] yarn install v1.22.17
[09:47:12.696] [1/4] Resolving packages...
[09:47:13.138] [2/4] Fetching packages...
[09:47:24.831] [1/5] Validating package.json...
[09:47:24.837] [2/5] Resolving packages...
[09:47:25.349] [3/5] Fetching packages...
[09:47:30.703] error https://registry.yarnpkg.com/atob/-/atob-2.1.2.tgz: Extracting tar content of undefined failed, the file appears to be corrupt: "ENOENT: no such file or directory, chmod '/vercel/.cache/yarn/v6/npm-atob-2.1.2-6d9517eb9e030d2436666651e86bd9f6f13533c9-integrity/node_modules/atob/bin/atob.js'"
[09:47:30.704] info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
[09:47:53.731] Error: Command "yarn install" exited with 1

Looks like it was temporary though, because rebuilding fixed it.