search

italia / cie-nis-python-sdk

SDK for reading the NIS code from an Italian Electronic Identity Card (CIE) using Python
BSD 3-Clause "New" or "Revised" License
30 stars 10 forks source link

Pull request for issue #1 #4

Closed HoochDeveloper closed 6 years ago

HoochDeveloper commented 6 years ago

Issue: https://github.com/italia/cie-nis-sdk/issues/1

Samples for reading NIS in C++, Java, Objective-C

alranel commented 6 years ago

Hello!

I initially merged your pull request because I thought about having a single cie-nis-sdk repository with your code and the Python one (from the other pull request) but I realized this would prevent us from having TravisCI running. So I'm going to create additional individual repositories for your code: cie-nis-java-sdk, cie-nis-objc-sdk, cie-nis-cpp-sdk.

I have one question before proceeding: why did you relicense the repository from BSD-3 (our preferred license) to Apache?

duncanwilcox commented 6 years ago

The MacOS code is derivative of https://github.com/dirkx/CryptoTokenKit-TrivialExample-OpenSC which is Apache licensed.

alranel commented 6 years ago

I just created three new repositories for your code and pulled it preserving history: https://github.com/italia/cie-nis-cpp-sdk https://github.com/italia/cie-nis-java-sdk https://github.com/italia/cie-nis-objc-sdk

Thank you for your contribution, and welcome to the community of Developers Italia as maintainers of the above repositories, on which you now have full admin rights 😃 (Remember: with great power comes great responsibility.)

I also invited you to become part of the italia organization, so that you can display its logo on your profile (don't forget to change the visibility after you accept the invitation!).