search

italia / covid19-dashboard-vaccini

[WIP] Unofficial example of the COVID-19 vaccinations dashboard
GNU Affero General Public License v3.0
24 stars 6 forks source link

the representation of the data for the Autonomous Province of Trento and the Autonomous Province of Bolzano are wrong #31

Closed napo closed 3 years ago

napo commented 3 years ago

I suppose the problem is related to the topojson used because this contains the geometry of the region Trentino-Alto Adige/Sudtirol. By starting from the shapefiles of ISTAT (regions and provinces) I created a new topojson with all the italian regions without the Trentino-Alto Adige / Sudtirol and, in substitution, the two geometries of the autonomous provinces. The file is in attachment in this message.

I suppose that replacing the file in public/data/geo/it.json with this and changing the variables in utils.js like so: PAB: "Autonomous Province of Bolzano", PAT: "Autonomous Province of Trento", you can fix the problem. I don't have enough time to a test.

note: the autonomous provinces of Trento and Bolzano manage the health care independently from the Region, for this reason the data cannot be presented in an aggregate way.

regioni_e_province_autonome.zip

sebbalex commented 3 years ago

Hi @napo and thanks for the issue. You have perfectly identified the problem! We will try to apply the patch you suggest or we would be even happier if you submit a PR.

Anyway, thanks for your time. :+1:

napo commented 3 years ago

Thanks @libremente for the answer and the invitation to send you a PR.

Before to write code I suggest you to solve the issue opened by @aborruso on the repository with the data. The suggestion is to use the common id keys of ISTAT and Eurostat to join the tables to the geographical entities.

IMHO: it's better if you use the NUTS2 code, so you can have an elegant and coherent solution to solve the problem of the rappresentation for the two autonomous provinces.

Today the @ondata team published also the geojson ready to be used (more or less it's like the file that I attached on my previous comment)

bfabio commented 3 years ago

Hello @napo, the official dashboard is at https://github.com/italia/report-vaccini-anti-covid-19 (https://www.governo.it/it/cscovid19/report-vaccini/). It should be already fixed there.

We're considering this repo as a quick example dashboard.