italia / design-react-kit

Il toolkit React conforme alle linee guida di design per i siti internet e i servizi digitali della PA.
https://italia.github.io/design-react-kit/
BSD 3-Clause "New" or "Revised" License
152 stars 80 forks source link

[BUG] ERESOLVE overriding peer dependency #1017

Closed Virtute90 closed 4 months ago

Virtute90 commented 5 months ago

Describe the bug When you install the package or upgrade installed packages with react >18.2.0, npm returns these warnings on peers:

npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: react-use-navscroll@0.2.0
npm WARN Found: react@18.2.0
npm WARN node_modules/react
npm WARN   peer react@"^16.8.0 || ^17.0.0" from react-select@4.3.1
npm WARN   node_modules/design-react-kit/node_modules/react-select
npm WARN     react-select@"^4.3.0" from design-react-kit@5.0.0-8
npm WARN     node_modules/design-react-kit
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer react@"^16.9.0" from react-use-navscroll@0.2.0
npm WARN node_modules/react-use-navscroll
npm WARN   react-use-navscroll@"0.2.0" from design-react-kit@5.0.0-8
npm WARN   node_modules/design-react-kit
npm WARN 
npm WARN Conflicting peer dependency: react@16.14.0
npm WARN node_modules/react
npm WARN   peer react@"^16.9.0" from react-use-navscroll@0.2.0
npm WARN   node_modules/react-use-navscroll
npm WARN     react-use-navscroll@"0.2.0" from design-react-kit@5.0.0-8
npm WARN     node_modules/design-react-kit
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency

To Reproduce npm install design-react-kit@unstable --save npm update

Expected behavior No warnings

Other Required Information (please complete the following information):

Suggestion Removing the react-use-navscroll package since it is not used by any component Updating from react-select to the latest version (https://react-select.com/upgrade)