italia / design-react-kit

Il toolkit React conforme alle linee guida di design per i siti internet e i servizi digitali della PA.
https://italia.github.io/design-react-kit/
BSD 3-Clause "New" or "Revised" License
152 stars 80 forks source link

fix: remove use navscroll #1019

Closed astagi closed 5 months ago

astagi commented 5 months ago

Fixes #1017

PR Checklist

Short description of what this resolves:

Changes proposed in this Pull Request:

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Feb 7, 2024 3:34pm
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (27016b7) 92.17% compared to head (0147ec6) 92.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1019 +/- ## ========================================== - Coverage 92.17% 92.13% -0.04% ========================================== Files 282 282 Lines 2825 2824 -1 Branches 720 720 ========================================== - Hits 2604 2602 -2 - Misses 217 218 +1 Partials 4 4 ``` | [Flag](https://app.codecov.io/gh/italia/design-react-kit/pull/1019/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=italia) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/italia/design-react-kit/pull/1019/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=italia) | `92.13% <ø> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=italia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

astagi commented 5 months ago

@Virtute90 this PR is wrong, removing this dependency causes errors for NavScroll. @sabato-galasso suggests to replace this package with https://github.com/fisshy/react-scroll