italia / design-react-kit

Il toolkit React conforme alle linee guida di design per i siti internet e i servizi digitali della PA.
https://italia.github.io/design-react-kit/
BSD 3-Clause "New" or "Revised" License
152 stars 80 forks source link

fix: replace use navscroll with react-scroll #1026

Closed Virtute90 closed 4 months ago

Virtute90 commented 5 months ago

First attempt to replace useNavScroll with react-scroll.

PR Checklist

Short description of what this resolves:

Changes proposed in this Pull Request:

The modification works quite well, there is only one problem to solve: the activeClass function on the ScrollLink component only works the first time the component is rendered. Both in the complete example with 4 components and with the test component. It could be a storybook problem, since the components are fetched (if I didn't misunderstand)

To be implemented

Version with InLine menu

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Mar 8, 2024 7:56am
astagi commented 4 months ago

Solved by #1030