search

italia / designers.italia.it

Designers Italia mette a disposizione la conoscenza e gli strumenti per progettare e realizzare servizi pubblici centrati sulle necessità delle persone
https://designers.italia.it
BSD 3-Clause "New" or "Revised" License
53 stars 36 forks source link

The examples from Bootstrap Italia API do not show icons. #1142

Open Fupete opened 7 months ago

Fupete commented 7 months ago

Does a discussion already exist on the topic you are interested in, or on a similar topic?

What

See comparison. Tab with icon. Left Documentation of the design system. Right Documentation of Bootstrap Italia. immagine

On the left the svg/use has href="/bootstrap-italia/dist/svg/sprites.svg#en-file and our website has /dist/svg/sprites.svg#en-file.

Did something change with one of the latest versions of Bootstrap Italia? Or did we do something? 🤔 Could it be related to https://github.com/italia/designers.italia.it/issues/1122?

@astagi @bfabio

Why

🔴 all the icons are gone, in all the DS examples...

Context

No response

More

No response

Fupete commented 7 months ago

I think we inserted the bug here https://github.com/italia/designers.italia.it/pull/907/files @bfabio @astagi immagine

Let's fix it ASAP.

Fupete commented 7 months ago

Update. This newly merged https://github.com/italia/designers.italia.it/pull/1137 will fix (revert) the bug entered on November 15. For example, see the Toolbar component.

But I just found that there are some components (e.g., Popover with icon) that still have the problem of not showing the icon. Perhaps this is another bug with the way we have been implementing BSI for a while now that we never discovered. We need to investigate more next week @astagi @bfabio .

Fupete commented 3 weeks ago

@astagi fyi take a look