italia / developers.italia.it

The developer community designing and developing public digital services in Italy
https://developers.italia.it
BSD 3-Clause "New" or "Revised" License
231 stars 116 forks source link

fix: use correct classes for outline buttons #1458

Closed smonolo closed 5 months ago

smonolo commented 5 months ago

Description

This PR introduces a series of fixes to outline buttons used around the website, which will occasionally have a strange behavior if btn-white class is not coupled with btn-outline-primary.

Checklist

Fixes

Fixes #1457

smonolo commented 5 months ago

Ready for review.

It might be also worth considering to create a shared component (include) with the buttons that exposes a prop to pass the Slack channel link, and import them everywhere is needed, so they will always look the same (right now they are all a copy paste).

bfabio commented 5 months ago

Thanks @smonolo, looks like #1327 and #1093 didn't cover every button in the site.

A shared include could be an improvement. More structural solutions, ordered by increasing levels of effort are: