search

italia / eudi-wallet-it-docs

Italian EUDI Wallet Technical Specifications
Creative Commons Zero v1.0 Universal
55 stars 18 forks source link

[credential_definition] type -> vct for sd-jwt and doctype for mdoc cbor #171

Closed peppelinux closed 9 months ago

peppelinux commented 10 months ago

see https://github.com/italia/eudi-wallet-it-docs/pull/166#issuecomment-1824572218

peppelinux commented 10 months ago

See https://github.com/italia/eudi-wallet-it-docs/pull/170

fmarino-ipzs commented 10 months ago

see also my comment https://github.com/italia/eudi-wallet-it-docs/pull/166#issuecomment-1824600299

peppelinux commented 10 months ago

@fmarino-ipzs it's not our choice, this comes from the standards OpenID4VC and HAIP

fmarino-ipzs commented 10 months ago

I fully agree that we must follow the standards, but in OID4VCI we have:

type: REQUIRED. Array designating the types a certain credential type supports according to [[VC_DATA](https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#VC_DATA)], Section 4.3.

Maybe this should be changed accordingly, am I missing something?

peppelinux commented 10 months ago

@fmarino-ipzs the type REQUIRED is defined within the appendix E, related to json-ld

E.1.1. VC Signed as a JWT, Not Using JSON-LD

this means that this is normative only for that credential format

peppelinux commented 9 months ago

Closed by https://github.com/openid/OpenID4VCI/commit/12d5ede25056daba991906e845d80128ad57572c