search

italia / eudi-wallet-it-docs

Italian EUDI Wallet Technical Specifications
Creative Commons Zero v1.0 Universal
56 stars 20 forks source link

Wallet Attestation registered claim does not include sub #360

Closed Zicchio closed 3 months ago

Zicchio commented 4 months ago

In the (non normative) example Wallet Attestation, which can be found here https://github.com/italia/eudi-wallet-it-docs/blob/e6bc7e37d8573d310c08d30efe112be0d50f15b8/docs/en/wallet-attestation.rst?plain=1#L324-L371

the claim sub appears with value equal to the jwk thumbprint of the key to be confirmed. On the other hand, the claim sub is not listed in the Walklet Attestation registered claim table, which can be found here https://github.com/italia/eudi-wallet-it-docs/blob/e6bc7e37d8573d310c08d30efe112be0d50f15b8/docs/en/wallet-attestation.rst?plain=1#L474-L515

It not clear to me wether the sub claim should appear or not, and what value should it have when it appears. If I understand correctly, this is a partial reference, referenced by this other reference suggest that sub claim should appear. If it must appear, it is still not clear to me wether its value should be the jwk thumprint of the cnf key or not.