search

italia / eudi-wallet-it-python

Python toolchain for building an OpenID4VP RP with a SATOSA backend compliant with the Italian Wallet implementation profile
Apache License 2.0
16 stars 9 forks source link

`./satosa/backend.py:507`: # TODO: handle vp token ops exceptions #160

Closed davidelongo-ey closed 8 months ago

salvatorelaiso commented 8 months ago

This issue is related to the following code:

https://github.com/italia/eudi-wallet-it-python/blob/bfabbe02534aae6003629233f70ba9257fc839f6/pyeudiw/satosa/backend.py#L431-L447

The TODO itself was written when the code was in the following state https://github.com/italia/eudi-wallet-it-python/blob/646086d9e62c00882a93c47ac690d91778244e0a/pyeudiw/satosa/backend.py#L367-L370

Can we consider the above try/except block enough to handle the exceptions? @peppelinux

peppelinux commented 8 months ago

Please specialize the Exceptions and provide the unit tests that cover all those exceptions