`./jwk/schema.py:9`: # TODO: verify if is optional

italia / eudi-wallet-it-python

Python toolchain for building an OpenID4VP RP with a SATOSA backend compliant with the Italian Wallet implementation profile

Apache License 2.0

16 stars 8 forks source link

`./jwk/schema.py:9`: # TODO: verify if is optional #170

Closed davidelongo-ey closed 7 months ago

salvatorelaiso commented 7 months ago

This TODO refers to the following:

https://github.com/italia/eudi-wallet-it-python/blob/43454bf31d22f67b0c5ee6a66da69efe1c27f9f0/pyeudiw/jwk/schema.py#L9-L22

According to the RFC 7517 section 4.4 it is indeed optional. Can we close this issue by simply removing its TODO in a dedicated PR or do we prefer to enforce the use of alg nonetheless? @peppelinux

peppelinux commented 7 months ago

@salvatorelaiso got It

Please remove that todo by reporting in the PR the evidence taken from rfc7517 and then close this issue

Thx