italia / eudi-wallet-it-python

Python toolchain for building an OpenID4VP RP with a SATOSA backend compliant with the Italian Wallet implementation profile
Apache License 2.0
17 stars 14 forks source link

Incompatible requirement between `setup.py` and CI pipeline #275

Open Zicchio opened 2 months ago

Zicchio commented 2 months ago

The dependency on https://github.com/openwallet-foundation-labs/sd-jwt-python is defined as:

  1. on the setup.py file, latest RELEASE is used (which currently is v0.10.4, commit 9181a0a4514b7de2cc30a84d320b509e9fc5cb59) https://github.com/italia/eudi-wallet-it-python/blob/8299616d4ae623822d71e9fcc7686d7d7fba7f65/setup.py#L55
  2. on the CI pipeline, the latest COMMIT is used https://github.com/italia/eudi-wallet-it-python/blob/8299616d4ae623822d71e9fcc7686d7d7fba7f65/.github/workflows/python-app.yml#L68

unfortunatly the two are currently not compatible for our puposes and the code currently assume that latest COMMIT (case 2) is used, see PR #250; in other word the current code is not compatible with latest release of sd-jwt

IMO we should either:

NOTE: this also has side effects on the project satosa-it, where case (1) is assumed https://github.com/italia/Satosa-Saml2Spid/blob/22c25951cfeb601f1582963d2c4440876e95bda9/requirements.txt#L24

peppelinux commented 2 months ago

I suggest to use the last dev version

I'm reaching Daniel Fett to release the next version 0.11 of sd-jwt, therefore alinged with the current dev branch

peppelinux commented 1 month ago

The solution will be achieved by this: https://github.com/italia/eudi-wallet-it-python/issues/281