search

italia / eudi-wallet-it-python

Python toolchain for building an OpenID4VP RP with a SATOSA backend compliant with the Italian Wallet implementation profile
Apache License 2.0
17 stars 14 forks source link

[Satosa][Bug] Incorrect QR code value in cross device flow #302

Closed Zicchio closed 3 days ago

Zicchio commented 1 week ago

The cross device flow containg a QR code with the wrong value: the link host is not satosa-pyeudiw itself but it should be the target wallet application. This is the line of code with the incorrect behaviour https://github.com/italia/eudi-wallet-it-python/blob/6a658f27d55a04129ca21c72e535f84d3b255004/pyeudiw/satosa/default/openid4vp_backend.py#L215-L218

The QR code should be a deep-link/universal-link/whatever much like in the same device flow as otherwise the user would not be able to open the holder app. In fact, it's the same link.

See https://italia.github.io/eudi-wallet-it-docs/versione-corrente/en/relying-party-solution.html#authorization-request-details

peppelinux commented 4 days ago

Confirmed, it must use the url configured here:

https://github.com/italia/eudi-wallet-it-python/blob/dev/example/satosa/pyeudiw_backend.yaml#L64