search

italia / publiccode-editor

A web editor to create and edit publiccode.yml files
https://publiccode-editor.developers.italia.it
GNU Affero General Public License v3.0
20 stars 25 forks source link

Error in npm install #61

Closed gtico80 closed 5 years ago

gtico80 commented 5 years ago

Subject of the issue

Npm install gives an error instead of installing packages. According to package.json definition version number must be parsable by node-semver.

Steps to reproduce

Execute npm install on the console.

Expected behaviour

Npm install must restore packages

Actual behaviour

$ npm install npm notice created a lockfile as package-lock.json. You should commit this file. npm WARN Invalid version: "1.1" npm WARN publiccode-editor No description npm WARN publiccode-editor No repository field. npm WARN publiccode-editor No README data npm WARN publiccode-editor No license field.

Node v10.13.0

gtico80 commented 5 years ago

Pull request #62

libremente commented 5 years ago

Thanks for the PR @gtico80. Merged now, let's switch to semantic versioning as it should be. :+1: