italia / spid-compliant-certificates

Solution to create self-signed certificates according to Avviso SPID n.29
MIT License
25 stars 13 forks source link

Remove hard-coded values in OpenSSL configuration file #6

Closed psmiraglia closed 3 years ago

psmiraglia commented 3 years ago

The key length and the digest algorithm are now hard-coded values

https://github.com/italia/spid-compliant-certificates/blob/d709afe6e94e548d53691b9bf9b40283057c73c7/gencert-public.sh#L23-L24

It would be better to have them configurable like in the following

default_bits=${KEY_LENGTH:=3072}
default_md=${MD_ALG:="sha256"}