search

italia / spid-django

SPID authentication for Django
Apache License 2.0
42 stars 20 forks source link

fix: Metadata Contacts telephone text #52

Closed peppelinux closed 3 years ago

peppelinux commented 3 years ago

fix: The TelephoneNumber element MUST not contain spaces fix: IPACode MUST be present

peppelinux commented 3 years ago

Hi Davide, that's something driven by AgID, phone number MUST be without spaces. IPACode MUST be validated using the national catalog

so, nothing that strictly belongs to my design principles. For CI (example/development mode) we can omit --production option for IPACode check, but nothing to do for phone number, it's mandatory mate!

brunato commented 3 years ago

Considering that --production is already implemented in the SP validator adding IPACode check management to it has perfectly sense.

For telephone number seems to be an over checking, considering that usually data sources (maybe also eIDAS) contain a space for separate international prefixes. But if this is a MUST in SPID regulations we have to accomplish that.