Code smell reduction - Githubissues

italia / spid-keycloak-provider

Italian SPID authentication provider for Keycloak (https://www.keycloak.org/)

Apache License 2.0

62 stars 22 forks source link

Code smell reduction #25

Closed matteobaccan closed 3 years ago

matteobaccan commented 3 years ago

I have improved the quality of the code, removing this code smell

Removed unnecessary imports
Use of diamond operator
Removed commented code

all the best matteo baccan

lscorcia commented 3 years ago

Hi @matteobaccan , thanks for your contribution. I will review it on a line-by-line basis, as I'm trying to keep the code aligned with Keycloak upstream files. If something "smells" but it's not in in my code I won't fix it as it would make diffs with upstream harder to understand.

matteobaccan commented 3 years ago

ok, in some situations I use the same way of works. It's not the best practice, but helps when "your father" update the code

ciao matteo