search

italia / spid-keycloak-provider

Italian SPID authentication provider for Keycloak (https://www.keycloak.org/)
Apache License 2.0
62 stars 22 forks source link

Check SPID SAML Response #32

Closed marcello-travaglini closed 2 years ago

marcello-travaglini commented 2 years ago

Sono stati implementati tutti i controlli sulla response SAML di Spid. E' stato introdotto uno switch, nella configurazione del identity provider, per abilitare e disabilitare i messaggi di debug. Per come sono strutturati i casi di test di AGID i seguenti check risultano uguali: 56 = 51, 84 = 73, 91 = 88, 93 = 90

lscorcia commented 2 years ago

Thanks for the contribution!

Since the IdP Entity ID validation should actually be performed for standard SAML federations too, I opened a PR against upstream Keycloak (https://github.com/keycloak/keycloak/pull/11084) that also adds automated tests for the feature.

I also reverted the change to the pom.xml (versioning is handled by maven release) and I reverted some import ordering that is intentionally not alphabetical to reduce code diffs against upstream Keycloak (helps in making sure the codebase is aligned to upstream code).

A few more days of testing and I'll publish a new release.

lscorcia commented 2 years ago

The upstream contribution has been merged and the issuer check is now part of Keycloak.