italia / spid-sp-simplesamlphp

SPID Service Provider SAML basato su SimpleSamlPhp
GNU Lesser General Public License v2.1
12 stars 8 forks source link

Notice: Undefined variable: spMetadata in ./modules/saml/lib/Message.php(515) #14

Open globogis opened 6 years ago

globogis commented 6 years ago

Si riferisce a questa funzione https://github.com/italia/spid-sp-simplesamlphp/blob/master/modules/saml/lib/Message.php##L507

   /**
     * Build a logout request based on information in the metadata.
     *
     * @param SimpleSAML_Configuration $srcMetadata The metadata of the sender.
     * @param SimpleSAML_Configuration $dstMetadata The metadata of the recipient.
     * @return \SAML2\LogoutRequest A logout request object.
     */
    public static function buildLogoutRequest(
        SimpleSAML_Configuration $srcMetadata,
        SimpleSAML_Configuration $dstMetadata
    ) {
        $lr = new \SAML2\LogoutRequest();
        //$lr->setIssuer($srcMetadata->getString('entityid'));
        $issuer = new \SAML2\XML\saml\Issuer();
        $issuer->Format="urn:oasis:names:tc:SAML:2.0:nameid-format:entity ";
        $issuer->NameQualifier=$spMetadata->getString('entityid');
        $issuer->value=$spMetadata->getString('entityid');
        $lr->setIssuer($issuer);

        self::addRedirectSign($srcMetadata, $dstMetadata, $lr);

        return $lr;
    }

vi è un refuso: dovrebbe essere così

   /**
     * Build a logout request based on information in the metadata.
     *
     * @param SimpleSAML_Configuration $srcMetadata The metadata of the sender.
     * @param SimpleSAML_Configuration $dstMetadata The metadata of the recipient.
     * @return \SAML2\LogoutRequest A logout request object.
     */
    public static function buildLogoutRequest(
        SimpleSAML_Configuration $srcMetadata,
        SimpleSAML_Configuration $dstMetadata
    ) {
        $lr = new \SAML2\LogoutRequest();
        //$lr->setIssuer($srcMetadata->getString('entityid'));
        $issuer = new \SAML2\XML\saml\Issuer();
-        $issuer->Format="urn:oasis:names:tc:SAML:2.0:nameid-format:entity ";
-        $issuer->NameQualifier=$spMetadata->getString('entityid');
-        $issuer->value=$spMetadata->getString('entityid');
+       $issuer->Format="urn:oasis:names:tc:SAML:2.0:nameid-format:entity";
+       $issuer->NameQualifier=$srcMetadata->getString('entityid');
+       $issuer->value=$srcMetadata->getString('entityid');
     $lr->setIssuer($issuer);

        self::addRedirectSign($srcMetadata, $dstMetadata, $lr);

        return $lr;
    }
manzolo commented 6 years ago

Confermo, anche nella personalizzazione fatta al Comune di Firenze abbiamo messo questa patch.