search

italia / spid-sp-test

SAML2 SPID/CIE Service Provider validation tool
European Union Public License 1.2
39 stars 17 forks source link

Checks for ContactPerson for pub-ag-full #109

Closed ewedlund closed 3 years ago

ewedlund commented 3 years ago

Metadata for type pub-ag-full should contain two entries of ContactPerson of type "other", one for the aggregator and one for the aggregated, but the test just checks for the aggregator ContactPerson, and gives an error when both are present.

https://github.com/italia/spid-sp-test/blob/10917dd825856e838944b0395972b2ff37cac345/src/spid_sp_test/metadata.py#L792

Testing a valid metadata:

spid_sp_test --metadata-url file:///path/to/metadata.xml -d ERROR
ERROR:spid_sp_test.metadata:SpidSpMetadataCheck.test_Contacts_PubPriv: Only one ContactPerson element of contactType "other" MUST be present
ERROR:spid_sp_test.metadata:Only one ContactPerson element of contactType "other" MUST be present
ewedlund commented 3 years ago

Sorry, saw it was fixed, but not published?