Add minimal check for Comparison #111

[ewedlund]

This should fix the cases where Comparison is "minimal" or "exact".

[peppelinux]

anyway @ewedlund I'm really interested in your contribution

we should cover this patch with some unit tests, take a look here https://github.com/italia/spid-sp-test/blob/main/tests/__init__.py#L51 https://github.com/italia/spid-sp-test/blob/main/tests/test_06_authnrequest.py

actually we only have authn and metadata unit tests and nothing for responses. It would be very important to have also these, this would let us to not test by hands on an existing sp

[peppelinux]

anyway again, @ewedlund do you thing that this solution is good for our intents? https://github.com/italia/spid-sp-test/pull/113/files

[ewedlund]

anyway again, @ewedlund do you thing that this solution is good for our intents? https://github.com/italia/spid-sp-test/pull/113/files

No, see my comment in that pull request.

[ewedlund]

anyway @ewedlund I'm really interested in your contribution

we should cover this patch with some unit tests, take a look here https://github.com/italia/spid-sp-test/blob/main/tests/__init__.py#L51 https://github.com/italia/spid-sp-test/blob/main/tests/test_06_authnrequest.py

actually we only have authn and metadata unit tests and nothing for responses. It would be very important to have also these, this would let us to not test by hands on an existing sp

Ok, I will look into it.

[peppelinux]

anyway again, @ewedlund do you thing that this solution is good for our intents? https://github.com/italia/spid-sp-test/pull/113/files

No, see my comment in that pull request.

you have to sumbit your revision, I can't read the comments yet

[peppelinux]

thank you @ewedlund You contribution was very appreciated!