Fix tests - Githubissues

italia / spid-sp-test

SAML2 SPID/CIE Service Provider validation tool

European Union Public License 1.2

39 stars 17 forks source link

Fix tests #128

Closed Einlar closed 2 years ago

Einlar commented 2 years ago

A few small things that confused me during testing. I think they are correct on spid-saml-check.

This PR fixes the following:

Tests 29 and 69 are checking the same thing (see case-29.xml and case-69.xml). It makes more sense for test 29 to check the Response Issuer instead.
case-98.xml and case-99.xml are missing the <saml:AttributeStatement> altogether, but their description explicitly says that it should be present.