search

italia / spid-sp-test

SAML2 SPID/CIE Service Provider validation tool
European Union Public License 1.2
39 stars 17 forks source link

Profile "spid-sp-ag-private-full" fails to validate metadata requested by "spid-avviso-n22v3-metadata_collaudo.pdf" #130

Closed rdndnl closed 2 years ago

rdndnl commented 2 years ago

Using the current dev branch, I'm trying to validate the metadata as required by Avviso nr. 22 – Versione 3.0 for SPID Private Aggregator. Here the relevant part:

 <md:ContactPerson contactType="other" spid:entityType="spid:aggregated">
    <md:Extensions>
      <spid:VATNumber>__aggrsint</spid:VATNumber>
      <spid:Private/>
    </md:Extensions>
    <md:Company>Organizzazione fittizia per il collaudo</md:Company>
  </md:ContactPerson>

Running the metadata validation I got:

$ spid_sp_test --profile spid-sp-ag-private-full --metadata-url http://localhost:8080/spid-public-full/saml/metadata
ERROR:spid_sp_test.metadata:The VATNumber element MUST start with a valid ISO3166 Code
Spid QA: executed 178 tests, 1 failed. 0 warnings.

Using ITXXXXXXXXXXX pattern as VATNumber all tests are OK.

peppelinux commented 2 years ago

Grazie @rdndnl abbiamo appena rilasciato la versione 1.2.0 per i soggetti aggregagatori privati, appena completiamo l'analisi con @nunzionapoli avremo questa correzione in 1.2.1 o superiori

peppelinux commented 2 years ago

Ciao @rdndnl abbiamo risolto qui https://github.com/italia/spid-sp-test/pull/139/files