italia / spid-sp-test

SAML2 SPID/CIE Service Provider validation tool
European Union Public License 1.2
38 stars 17 forks source link

Correctly support all comparisons as per SPID specs #146

Closed mauromol closed 2 years ago

mauromol commented 2 years ago

In particular, with comparison="exact" the SP must accept even higher established authentication levels. This should also correctly support "maximum" and "better".

Closes #124.

@peppelinux I don't know Python, so please bear with me if I made some mistake. In particular, please check that the error handling in dynamic_acr is still correct. I made some tests with my SPID implementation, by trying all comparison values and it seems to work.

peppelinux commented 2 years ago

Ok @mauromol I think that's pretty good

Please in init.py increase the release Number, then I'll merge this and I'll do a new release

mauromol commented 2 years ago

Please in init.py increase the release Number, then I'll merge this and I'll do a new release

Done!