italia / verificac19-sdk

✅ Official VerificaC19 Node.js SDK
MIT License
49 stars 17 forks source link

fix: recovery statement validation #15 #16

Closed astagi closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #16 (de65e72) into master (df2f369) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   98.40%   98.41%           
=======================================
  Files           7        7           
  Lines         251      252    +1     
=======================================
+ Hits          247      248    +1     
  Misses          4        4           
Impacted Files Coverage Δ
src/validator.js 97.12% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df2f369...de65e72. Read the comment docs.

herald-si commented 2 years ago

Ciao Andrea,

la logica sembra quella prevista, attento che in questo commit è stato sostituito endDate con startDate, da sommare al setting end_day:

https://github.com/ministero-salute/it-dgc-verificac19-sdk-android/commit/124ff85a51b69c82461acd98eaf569dc7e07a434

astagi commented 2 years ago

@herald-si si devo aver fatto confusione, l'ultimo commit dovrebbe aver risolto!