Open anversoft opened 2 years ago
To reuse the old caching method just create a new file and copy the contents of ./src/cache.js
and create a new class while calling the methods listed above
Merging #40 (3469ed5) into master (6326798) will decrease coverage by
1.17%
. The diff coverage is95.42%
.
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 98.44% 97.26% -1.18%
==========================================
Files 8 9 +1
Lines 513 659 +146
==========================================
+ Hits 505 641 +136
- Misses 8 18 +10
Impacted Files | Coverage Δ | |
---|---|---|
src/cache.js | 93.75% <78.57%> (-6.25%) |
:arrow_down: |
src/service.js | 93.54% <91.17%> (-2.40%) |
:arrow_down: |
src/mongocache.js | 98.14% <98.14%> (ø) |
|
src/index.js | 100.00% <100.00%> (ø) |
|
src/validator.js | 98.30% <100.00%> (+0.03%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6326798...3469ed5. Read the comment docs.
Edit, to reuse the old method just use Service.updateAll(null, new FileCache())
everytime
Really cool feature @anversoft I need to review it deeply. I suppose this feature resolves https://github.com/italia/verificac19-sdk/issues/23, does it? cc @albertorizzi
I moved everything about the cache to the Mongo database so that any validation servers can be synchronized on a single database, the only substantial difference is that now the
Service.updateAll(crl?: CRL, cache?: Cache)
andService.setUp(crl?: CRL, cache?: Cache)
entries accept a custom Cache object as an optional second argument.