italomaia / flask-empty

An empty project skeleton / boilerplate for flask projects. Powered by CookieCutter.
667 stars 93 forks source link

Debug option in Config file does nothing when using Flask-Script #1

Closed joequery closed 10 years ago

joequery commented 12 years ago

If you're using Flask-Script, the Debug option does nothing. This can be very frustrating for those who don't know how Flask-Script works. Flask script overrides any Debug config and looks for command line arguments passed when executing runserver. For example,

python manager.py runserver -r -d

This says "Run with no reload and no debug".

You can see how it's hardcoded in Flask-Script itself: https://github.com/joequery/flask-script/blob/master/flask_script.py#L319-320

italomaia commented 12 years ago

Hi Joe. The proper way to set debug with flask-empty is through configuration classes or environment settings, as visible (undocummented) here https://github.com/italomaia/flask-empty/blob/master/src/0.8/main.py#L41 Anyway, this behavior was, also, undocumented. Now it is documented in the readme.

Besides that, your issue made me see that there was a bug with the -c option added by flask-empty. Now it is fixed since https://github.com/italomaia/flask-empty/commit/1cf8fd0c0597b719cc11901051ea1f857357203a

joequery commented 12 years ago

The proper way to set debug with flask-empty is through configuration classes or environment settings

I know this. I'm not sure if your latest commit fixed it, but setting all occurrences of Debug to False in the example did not change the reloader. It is hardcoded into Flask-Script to activate the reloader and the debugger unless overridden by command line arguments.

italomaia commented 10 years ago

Joequery, do you still have this problem? It is working for me.

joequery commented 10 years ago

I'll take your word for it, I haven't seen this thread in over two years ;)