italomandara / CXPatcher

A patcher to upgrade Crossover dependencies and improve compatibility
GNU General Public License v3.0
834 stars 22 forks source link

crossover.inf obsolete for Crossover 23.5 #141

Closed MysticalOS closed 9 months ago

MysticalOS commented 9 months ago

the inf it copies actually has a lot of 22.x presets and not 23. for example. Patcher removes windows 11 from it. (Win11Install)

Also, i see this is still using uplay and steam override fixes 22.x needed but 23.x does not. So @Gcenx should probably review the inf for 23.5 version to make sure nothing redundant isn't added and nothing useful is being removed.

MysticalOS commented 9 months ago

oh, it looks like you caught that already here https://github.com/italomandara/CXPatcher/commit/0caedaf20fa6e351fee8c8a83d538b4c95bbdfdb

Forgot to check branches :D

Gcenx commented 9 months ago

While @italomandara updated the file for CrossOver-23.5.0 it reverted to an older Win10 build that might cause issues with some newer games, I've pushed a commit to bump the Win10 build.

MysticalOS commented 9 months ago

What's funny is I was just gonna post about wine mono too (was doing side by side diffs) 👍 Great work

Gcenx commented 9 months ago

What's funny is I was just gonna post about wine mono too (was doing side by side diffs) 👍 Great work

Yeah the wine-mono bump was specific to getting EA-app working with CrossOver-22.x, CrossOver-23.x already includes this exact version.