italomandara / CXPatcher

A patcher to upgrade Crossover dependencies and improve compatibility
GNU General Public License v3.0
831 stars 22 forks source link

Improve wording in release notes & in the toggle to make CrossOver not auto update #189

Open rxhfcy opened 2 months ago

rxhfcy commented 2 months ago

This page: https://github.com/italomandara/CXPatcher/releases/tag/v0.5 has the following (see screen shot)

What does this mean

Question:

What does "OR DISABLE THIS" mean in this context?

Disable the "Disable" toggle? or Enable the "Disable" toggle?

Suggestion:

Could the toggle text itself + the help text in the "release notes" be made more explicit/clear please?

For the toggle: Something like "Make CrossOver not auto update", or whatever the toggle does/means?

For the text: "Change this toggle to "enabled" (or "disabled"), to make it look like this:" or something

rxhfcy commented 2 months ago

v0.5.1 is much better, but to nitpick:

Better
italomandara commented 2 months ago

Any suggestions? "Prevent CrossOver auto update" maybe?

rxhfcy commented 2 months ago

Any suggestions? "Prevent CrossOver auto update" maybe?

Sounds fine to me (pretty minimal change but would be much better I think).

italomandara commented 2 months ago

ok done

italomandara commented 2 months ago

https://github.com/italomandara/CXPatcher/commit/bc4685c30e27fcf515381ec24b401e3f4f8e3fc1

rxhfcy commented 2 months ago

BTW doesn't this have a similar problem? The user has to "enable" this in order to "disable" something?

"autoUpdateToggleHelp" = "Disable CrossOver's update check prompt";

(I don't actually understand what the string means in context, but) -> "Prevent CrossOver something something"?

italomandara commented 2 months ago

Crossover has an auto update feature and it's part of the app, you can't disable it normally, the toggle enables a hack that removes the ability to auto update.

rxhfcy commented 2 months ago

"Enable hack to remove CrossOver auto update feature"? :)

My point is that it can feel somewhat silly to enable to disable

Stromweld commented 2 months ago

It's a switch so can think of it as on/off or true/false instead of enable/disable. switch on for disable auto update = true.

rxhfcy commented 2 months ago

Sure, just a random comment