italomandara / CXPatcher

A patcher to upgrade Crossover dependencies and improve compatibility
GNU General Public License v3.0
963 stars 24 forks source link

V0.2.15 and external resources #43

Closed MysticalOS closed 1 year ago

MysticalOS commented 1 year ago

I can't find any evidence external resources actually works what so ever. The patched version of application is identical whether it's enabled or disabled. and no dx12 games work following instructions to letter.

It doesn't copy the required framework anywhere into binary it doesn't copy the modified d3d to metal libs to binary even when you select the porting kit disk before doing so. Far as i can tell it's same as if external option was not selected.

MysticalOS commented 1 year ago

Just to add, I copied the files manually after using patcher and it works fine. so for some reason, despite selecting the mounted disk image for porting kit, it didn't actually auto copy any files.

successfully playing diablo 4 in crossover directly, using patcher and manually copying files that didn't copy over though.

italomandara commented 1 year ago

Please make sure you followed the steps correctly, try the instructions here: https://www.youtube.com/watch?v=VVwX-cMKUPk. There must be something that happened during the steps, maybe you didn't select the drive correctly? perhaps you selected the folder instead of the volume?

MysticalOS commented 1 year ago

I followed it to the letter. I even used that video as a guide. I selected the volume, did patching, it didn't copy any files at all from the volume. not a one. is it possible the volume name mismatches based on WHEN you downloaded it? I couldn't find the script in source code to determine what it's actually looking for to find out.

MysticalOS commented 1 year ago

Did more testing, it's copying some of the files, just not the actual "lib/external" folder and framework therein. it did copy libs/wine/ contents over, but the libs/external folder was not, and without that it doesn't fully work.

italomandara commented 1 year ago

I followed it to the letter. I even used that video as a guide. I selected the volume, did patching, it didn't copy any files at all from the volume. not a one. is it possible the volume name mismatches based on WHEN you downloaded it? I couldn't find the script in source code to determine what it's actually looking for to find out.

The volume name is the one you select the only fixed path is /lib/ I’ll re-download gptk dmg and try again, but this is the first time i hear of this issue, it seems to work for everyone else maybe it’s a permission issue, but you should be prompted with the auth

italomandara commented 1 year ago

Ill see if i can add logfiles tonights so that we have something to investigate. what’s happening is really weird

ryantrip commented 1 year ago

I'm running into the same issue, let me know if there's anything I can provide. Should the "External" folder be placed within "Lib" under CrossOver like this?

image
italomandara commented 1 year ago

I'm running into the same issue, let me know if there's anything I can provide. Should the "External" folder be placed within "Lib" under CrossOver like this?

image

yes that's where it should be copied

ryantrip commented 1 year ago

Thank you, I was able to resolve the issue by copying all the files together manually and merging them with the existing files behind CrossOver.

MysticalOS commented 1 year ago

Yeah I just encountered another user on gaming discord that had same problem

italomandara commented 1 year ago

I'll add a logging option in the next release so that we can investigate this better

italomandara commented 1 year ago

I removed 0.2.15 since it needs some investigation, V0.2.14 should work as usual

italomandara commented 1 year ago

@MysticalOS @ryantrip thanks for reporting this, I've opened a PR to fix the issue if you want to test: https://github.com/italomandara/CXPatcher/pull/47

italomandara commented 1 year ago

the fix has been tested and now works