search

itamarst / crochet

Crochet: use Twisted anywhere!
MIT License
236 stars 35 forks source link

Replace deprecated imp module with importlib #145

Closed hugovk closed 1 year ago

hugovk commented 1 year ago

This project's tests use the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

https://github.com/itamarst/crochet/blob/deea55f870028c241e0b8c64c317224fb571b78a/crochet/tests/test_api.py#L540-L564

itamarst commented 1 year ago

I should probably just delete that test, I suspect it's not really necessary in modern Python.

itamarst commented 1 year ago

Or just switch to importing a module with a sleep that runs at import time.