search

itamarst / eliot

Eliot: the logging system that tells you *why* it happened
https://eliot.readthedocs.io
Apache License 2.0
1.1k stars 66 forks source link

Make eliot._parse public so eliot-tree isn't depending on private API #328

Closed itamarst closed 5 years ago

itamarst commented 6 years ago

eliot-tree depends on eliot._parse, which is private. Really, it's a stable API, and it should be useful to others as well.

So:

  1. Make it public.
  2. Add backwards compat eliot._parse for old eliot-tree installs.
  3. Document it, at least a little.

CC @jonathanj

jonathanj commented 6 years ago

Sounds good to me. The only thing that occurs to me is that the minimum Eliot version that eliot-tree depends on would jump up from 0.12.0 to 1.6.0, but any users who can't upgrade Eliot can still continue using older versions of eliot-tree.