search

itamarst / eliot

Eliot: the logging system that tells you *why* it happened
https://eliot.readthedocs.io
Apache License 2.0
1.1k stars 66 forks source link

DeferredContext.addCallbacks isn't signature-compatible with Deferred.addCallbacks #366

Closed exarkun closed 5 years ago

exarkun commented 5 years ago

It is allowed to d.addCallbacks(f) though there's no benefit to this over d.addCallback(f) that I know of. However, since it's allowed, surprise, someone does it.

When the Deferred d is replaced with a DeferredContext, though, this fails because DeferredContext.addCallbacks requires an errback.

itamarst commented 5 years ago

Want to submit a quick patch?

exarkun commented 5 years ago

Sure